New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): prevent toggle click from closing in collapsed navbar #1475

Merged
merged 2 commits into from Dec 17, 2017

Conversation

Projects
None yet
1 participant
@tmorehouse
Member

tmorehouse commented Dec 17, 2017

Fixes #1474

@codecov

This comment has been minimized.

codecov bot commented Dec 17, 2017

Codecov Report

Merging #1475 into dev will increase coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1475      +/-   ##
==========================================
+ Coverage   53.11%   53.26%   +0.14%     
==========================================
  Files         134      134              
  Lines        2197     2191       -6     
  Branches      701      698       -3     
==========================================
  Hits         1167     1167              
+ Misses        731      728       -3     
+ Partials      299      296       -3
Impacted Files Coverage Δ
src/mixins/dropdown.js 5.93% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534b4b7...7a59c38. Read the comment docs.

@tmorehouse tmorehouse merged commit 24ef1e6 into dev Dec 17, 2017

3 of 4 checks passed

codecov/patch 0% of diff hit (target 53.11%)
Details
License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 53.26% (+0.14%) compared to 534b4b7
Details

@tmorehouse tmorehouse deleted the fix/dropdown branch Dec 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment