New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): fix condition for when position-static is applied #1477

Merged
merged 1 commit into from Dec 17, 2017

Conversation

Projects
None yet
1 participant
@tmorehouse
Member

tmorehouse commented Dec 17, 2017

Class .position-static should be applied only when boundary is not scrollParent

fix(dropdown): fix condition for when position-static is applied
position-static should be applied only when boundary is **not** `scrollParent`
@codecov

This comment has been minimized.

codecov bot commented Dec 17, 2017

Codecov Report

Merging #1477 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1477   +/-   ##
=======================================
  Coverage   53.26%   53.26%           
=======================================
  Files         134      134           
  Lines        2191     2191           
  Branches      698      698           
=======================================
  Hits         1167     1167           
  Misses        728      728           
  Partials      296      296
Impacted Files Coverage Δ
src/components/dropdown/dropdown.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68deee1...f845408. Read the comment docs.

@tmorehouse tmorehouse merged commit 1717edb into dev Dec 17, 2017

3 of 4 checks passed

License Compliance FOSSA analyzing commit
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 68deee1...f845408
Details
codecov/project 53.26% remains the same compared to 68deee1
Details

@tmorehouse tmorehouse deleted the fix/dropdown branch Dec 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment