New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggleClass prop to b-dropdown #1485

Merged
merged 3 commits into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@jpkleemans
Contributor

jpkleemans commented Dec 21, 2017

Allows to add css classes to the toggle button of <b-dropdown>

@pi0

This comment has been minimized.

Member

pi0 commented Jan 3, 2018

Thanks. Would you please fix tests and add some example into docs for usage?

@codecov

This comment has been minimized.

codecov bot commented Jan 3, 2018

Codecov Report

Merging #1485 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1485   +/-   ##
=======================================
  Coverage   53.26%   53.26%           
=======================================
  Files         134      134           
  Lines        2191     2191           
  Branches      698      698           
=======================================
  Hits         1167     1167           
  Misses        728      728           
  Partials      296      296
Impacted Files Coverage Δ
src/components/dropdown/dropdown.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f64cef2...1183506. Read the comment docs.

@pi0

This comment has been minimized.

Member

pi0 commented Jan 23, 2018

Sorry for late merge. Will be available in 2.0.0-rc soon.

@pi0 pi0 merged commit da16cc0 into bootstrap-vue:dev Jan 23, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f64cef2...1183506
Details
codecov/project 53.26% remains the same compared to f64cef2
Details
@jpkleemans

This comment has been minimized.

Contributor

jpkleemans commented Jan 23, 2018

NP! Thanks

@jpkleemans jpkleemans deleted the jpkleemans:patch-1 branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment