Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(id): fixed check for _uid in id generator #1499
@@ Coverage Diff @@ ## dev #1499 +/- ## ======================================= Coverage 53.26% 53.26% ======================================= Files 134 134 Lines 2191 2191 Branches 698 698 ======================================= Hits 1167 1167 Misses 728 728 Partials 296 296
The problem occured when I tried to extend the component and then run it in my unit tests. In cases when the component was first in order there was an error because id wasn't generating correctly.…
On Dec 28, 2017 23:16, "Troy Morehouse" ***@***.***> wrote: Usually, the root vue instance has a uid of 0, and your components would have 1 and up, but this pr is a good additional check — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1499 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKoqjNSj7OdsbCQY7lZQsciB1bFX01cks5tE77FgaJpZM4ROSS0> .
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.