New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(id): fixed check for _uid in id generator #1499

Merged
merged 1 commit into from Dec 28, 2017

Conversation

Projects
None yet
2 participants
@larionov
Contributor

larionov commented Dec 28, 2017

On the first run _uid === 0 and this value fails the check not generating an id for the component.

fix(id): fixed check for _uid in id generator
On the first run _uid === 0 and this value fails the check not generating an id for the component.
@codecov

This comment has been minimized.

codecov bot commented Dec 28, 2017

Codecov Report

Merging #1499 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1499   +/-   ##
=======================================
  Coverage   53.26%   53.26%           
=======================================
  Files         134      134           
  Lines        2191     2191           
  Branches      698      698           
=======================================
  Hits         1167     1167           
  Misses        728      728           
  Partials      296      296
Impacted Files Coverage Δ
src/mixins/id.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32e4ca...b64dd60. Read the comment docs.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Dec 28, 2017

Usually, the root vue instance has a uid of 0, and your components would have 1 and up, but this pr is a good additional check

@tmorehouse tmorehouse merged commit f3fe0f4 into bootstrap-vue:dev Dec 28, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 53.26%)
Details
codecov/project 53.26% (+0%) compared to f32e4ca
Details
@larionov

This comment has been minimized.

Contributor

larionov commented Dec 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment