New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1522: Import button-close in alert with a name matching tag. #1523

Merged
merged 1 commit into from Jan 13, 2018

Conversation

Projects
None yet
2 participants
@mehdirande
Contributor

mehdirande commented Jan 10, 2018

bButtonClose component was imported in alert with the shortcut alias
(bBtnClose) but used with the full tag (b-button-close). When importing
b-alert as an individual component b-button-close alias was not set and
vue failed to import the b-button-close component.
Importing bButtonClose component with the fullname fix #1522 .

Fix #1522: Import button-close in alert with a name matching tag.
bButtonClose component was imported in alert with the shortcut alias
(bBtnClose) but used with the full tag (b-button-close). When importing
b-alert as an individual component b-button-close alias was not set and
vue failed to import the b-button-close component.
Importing bButtonClose component with the fullname fix this issue.
@codecov

This comment has been minimized.

codecov bot commented Jan 10, 2018

Codecov Report

Merging #1523 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1523   +/-   ##
=======================================
  Coverage   53.26%   53.26%           
=======================================
  Files         134      134           
  Lines        2191     2191           
  Branches      698      698           
=======================================
  Hits         1167     1167           
  Misses        728      728           
  Partials      296      296
Impacted Files Coverage Δ
src/components/alert/alert.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace3e94...b1414f0. Read the comment docs.

@pi0

This comment has been minimized.

Member

pi0 commented Jan 13, 2018

Thanks.

@pi0 pi0 merged commit 51b527f into bootstrap-vue:dev Jan 13, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing ace3e94...b1414f0
Details
codecov/project 53.26% remains the same compared to ace3e94
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment