New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Tab) add title slot #1586

Merged
merged 4 commits into from Feb 4, 2018

Conversation

Projects
None yet
2 participants
@mosinve
Member

mosinve commented Feb 4, 2018

As requested at #1583
fixes #1583

@codecov

This comment has been minimized.

codecov bot commented Feb 4, 2018

Codecov Report

Merging #1586 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1586   +/-   ##
=======================================
  Coverage   59.96%   59.96%           
=======================================
  Files         153      153           
  Lines        2850     2850           
  Branches      782      782           
=======================================
  Hits         1709     1709           
  Misses        821      821           
  Partials      320      320
Impacted Files Coverage Δ
src/components/tabs/tabs.js 64.44% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7202c35...3d689da. Read the comment docs.

@mosinve mosinve force-pushed the feat-tab-title-slot branch from b225b2c to f4fa8b0 Feb 4, 2018

@mosinve mosinve requested a review from pi0 Feb 4, 2018

@pi0

pi0 approved these changes Feb 4, 2018

@mosinve mosinve merged commit 724b453 into dev Feb 4, 2018

5 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7202c35...3d689da
Details
codecov/project 59.96% remains the same compared to 7202c35
Details
deploy/netlify Deploy preview ready!
Details

@mosinve mosinve deleted the feat-tab-title-slot branch Feb 4, 2018

@Morgul Morgul referenced this pull request Feb 9, 2018

Closed

Feature: Tab Prefix/Suffix #1520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment