New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass selectSize to selects #1640

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
2 participants
@robcresswell
Contributor

robcresswell commented Feb 28, 2018

The size attribute is not specific to multiple-select fields: it can be
used on single selects on both Bootstrap and raw HTML. We could probably
pass the value straight through instead of renaming it "selectSize",
but I'd like to avoid making a breaking API change at this stage.

Fixes #1639

Rob Cresswell
Always pass selectSize to selects
The size attribute is not specific to multiple-select fields: it can be
used on single selects on both Bootstrap and raw HTML. We could probably
pass the value straight through instead of renaming it "selectSize",
but I'd like to avoid making a breaking API change at this stage.

Fixes #1639
@codecov

This comment has been minimized.

codecov bot commented Feb 28, 2018

Codecov Report

Merging #1640 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1640   +/-   ##
=======================================
  Coverage   60.64%   60.64%           
=======================================
  Files         153      153           
  Lines        2869     2869           
  Branches      788      788           
=======================================
  Hits         1740     1740           
  Misses        809      809           
  Partials      320      320
Impacted Files Coverage Δ
src/components/form-select/form-select.js 65% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048c3d4...e61e1ad. Read the comment docs.

@mosinve mosinve merged commit 2c725f6 into bootstrap-vue:dev Feb 28, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 048c3d4...e61e1ad
Details
codecov/project 60.64% remains the same compared to 048c3d4
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment