New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added `menuClass` prop to `bDropdown` #1683

Merged
merged 2 commits into from Mar 31, 2018

Conversation

Projects
None yet
2 participants
@RomeroMsk
Contributor

RomeroMsk commented Mar 15, 2018

Solves #1649

@codecov

This comment has been minimized.

codecov bot commented Mar 15, 2018

Codecov Report

Merging #1683 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #1683   +/-   ##
=====================================
  Coverage   60.8%   60.8%           
=====================================
  Files        154     154           
  Lines       2873    2873           
  Branches     790     790           
=====================================
  Hits        1747    1747           
  Misses       806     806           
  Partials     320     320
Impacted Files Coverage Δ
src/components/nav/nav-item-dropdown.js 87.5% <ø> (ø) ⬆️
src/components/dropdown/dropdown.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a10ef...4481fcf. Read the comment docs.

@pi0

pi0 approved these changes Mar 31, 2018

@pi0

This comment has been minimized.

Member

pi0 commented Mar 31, 2018

Sorry for the delay. Thanks.

@pi0 pi0 merged commit 3da5f18 into bootstrap-vue:dev Mar 31, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing c7a10ef...4481fcf
Details
codecov/project 60.8% remains the same compared to c7a10ef
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment