New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): import lodash.get from "dependencies" #1697

Merged
merged 1 commit into from Mar 31, 2018

Conversation

Projects
None yet
2 participants
@rjmill
Contributor

rjmill commented Mar 21, 2018

This fixes a breaking bug in the latest update, where table can't compile because lodash/get is not in node_modules. Here's the error message I'm getting:

ERROR in ./node_modules/bootstrap-vue/es/components/table/table.js
Module not found: Error: Can't resolve 'lodash/get' in '/home/rjmill/Development/build-chain/node_modules/bootstrap-vue/es/
components/table'
 @ ./node_modules/bootstrap-vue/es/components/table/table.js 4:0-29
 @ ./node_modules/bootstrap-vue/es/components/table/index.js
 @ ./node_modules/bootstrap-vue/es/components/index.js
 @ ./node_modules/bootstrap-vue/es/index.js
 @ ./src/main.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 webpack/hot/dev-server babel-polyfill ./src/main.js

lodash.get was being imported from lodash/get, even though the lodash package is not in dependencies. (lodash is in devDependencies, however, which is why the tests are still passing.)

This PR adds lodash.get to dependencies and changes the import statement to pull in get from lodash.get instead of lodash/get

This fixes an issue that looks like #1670. I can open a new issue with more details if need be. Opening a PR with a fix just seemed quicker than describing the problem in an issue :)

Let me know if you need me to change/add anything for this PR. The latest release of bootstrap-vue is unusable in my project until this issue is resolved.

@codecov

This comment has been minimized.

codecov bot commented Mar 21, 2018

Codecov Report

Merging #1697 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #1697   +/-   ##
=====================================
  Coverage   60.8%   60.8%           
=====================================
  Files        154     154           
  Lines       2873    2873           
  Branches     790     790           
=====================================
  Hits        1747    1747           
  Misses       806     806           
  Partials     320     320
Impacted Files Coverage Δ
src/components/table/table.js 72.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a10ef...f25bd7c. Read the comment docs.

@pi0

This comment has been minimized.

Member

pi0 commented Mar 31, 2018

Sorry for the delay. Thanks.

@pi0 pi0 merged commit 4d620a5 into bootstrap-vue:dev Mar 31, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing c7a10ef...f25bd7c
Details
codecov/project 60.8% remains the same compared to c7a10ef
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment