New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): Make show/hide events cancelable + Add toggle event #1807

Merged
merged 10 commits into from May 17, 2018

Conversation

Projects
None yet
2 participants
@jackmu95
Contributor

jackmu95 commented May 9, 2018

No description provided.

jackmu95 added some commits May 9, 2018

@codecov

This comment has been minimized.

codecov bot commented May 9, 2018

Codecov Report

Merging #1807 into dev will decrease coverage by 0.27%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1807      +/-   ##
==========================================
- Coverage   61.04%   60.76%   -0.28%     
==========================================
  Files         154      154              
  Lines        2862     2875      +13     
  Branches      791      795       +4     
==========================================
  Hits         1747     1747              
- Misses        800      809       +9     
- Partials      315      319       +4
Impacted Files Coverage Δ
src/mixins/dropdown.js 7.14% <0%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a35374...57bce17. Read the comment docs.

@pi0 pi0 merged commit 4136bd9 into bootstrap-vue:dev May 17, 2018

6 of 8 checks passed

codecov/patch 0% of diff hit (target 61.04%)
Details
codecov/project 60.76% (-0.28%) compared to 8a35374
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-beta Your tests passed on CircleCI!
Details
ci/circleci: test-latest Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@pi0

This comment has been minimized.

Member

pi0 commented May 17, 2018

Thanks :)

@tmorehouse tmorehouse referenced this pull request Nov 14, 2018

Open

Bootstrap-Vue V2.0.0 Tracker #2173

69 of 80 tasks complete

@jackmu95 jackmu95 deleted the jackmu95:feat/dropdown-show-hide-events-cancelable branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment