New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab): fix the delay in tab transition #1812

Merged
merged 1 commit into from May 17, 2018

Conversation

Projects
None yet
2 participants
@rinick
Contributor

rinick commented May 10, 2018

after this change, bootstrap-vue tab transition has the same behavior as original bootstrap.
hide of the previous tab happens instantly, and the new tab have a 0.15s animation. resolves #1806

@codecov

This comment has been minimized.

codecov bot commented May 10, 2018

Codecov Report

Merging #1812 into dev will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1812      +/-   ##
==========================================
+ Coverage   61.04%   61.06%   +0.02%     
==========================================
  Files         154      154              
  Lines        2862     2861       -1     
  Branches      791      791              
==========================================
  Hits         1747     1747              
+ Misses        800      799       -1     
  Partials      315      315
Impacted Files Coverage Δ
src/components/tabs/tab.js 92.3% <100%> (+6.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a35374...e7e70e9. Read the comment docs.

@pi0 pi0 merged commit 5a7a290 into bootstrap-vue:dev May 17, 2018

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-beta Your tests passed on CircleCI!
Details
ci/circleci: test-latest Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 61.04%)
Details
codecov/project 61.06% (+0.02%) compared to 8a35374
Details
deploy/netlify Deploy preview ready!
Details
@pi0

This comment has been minimized.

Member

pi0 commented May 17, 2018

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment