New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-input): force update formatted value #1845

Merged
merged 3 commits into from May 20, 2018

Conversation

Projects
None yet
5 participants
@farnabaz
Contributor

farnabaz commented May 19, 2018

When fromatter function removes last char from value, text input does not update and character still visible in text input
We could update value of text input directly using its reference

Most of this changes done by @pi0 so all credits goes to him

farnabaz added some commits May 19, 2018

fix(form-input): force update formatted value
When fromatter function removes last char from value, text input does not update and character still visible in text input
We could update value of text input directly using its reference
Most of this changes are done by @pi0
@codecov

This comment has been minimized.

codecov bot commented May 19, 2018

Codecov Report

Merging #1845 into dev will decrease coverage by 0.02%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1845      +/-   ##
==========================================
- Coverage   60.85%   60.83%   -0.03%     
==========================================
  Files         154      154              
  Lines        2879     2885       +6     
  Branches      798      798              
==========================================
+ Hits         1752     1755       +3     
- Misses        808      812       +4     
+ Partials      319      318       -1
Impacted Files Coverage Δ
src/components/form-input/form-input.js 46.87% <37.5%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7520554...3cf918b. Read the comment docs.

@pi0

pi0 approved these changes May 20, 2018

@pi0 pi0 merged commit 497cc6e into bootstrap-vue:dev May 20, 2018

6 of 8 checks passed

codecov/patch 37.5% of diff hit (target 60.85%)
Details
codecov/project 60.83% (-0.03%) compared to 7520554
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-beta Your tests passed on CircleCI!
Details
ci/circleci: test-latest Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@ericdrobinson

This comment has been minimized.

ericdrobinson commented May 25, 2018

This commit broke form input elements when used in Adobe CEP 8 contexts. It results in constantly triggering this bug.

Adobe CEP (Common Extensibility Platform) is the extension system that Adobe uses for current Creative Cloud applications. See this documentation for an overview.

Adobe is aware of the bug on their end. That said, BootstrapVue did not exhibit any related issues until this change came in. My hunch is that something around here is the cause.

@pi0

This comment has been minimized.

Member

pi0 commented May 25, 2018

@ericdrobinson Thanks for your report. I would be happy to release a fix ASAP. But we need more information and probably a reproduction example. Would you please open an issue with more details?

@ericdrobinson

This comment has been minimized.

ericdrobinson commented May 25, 2018

@pi0 See ↑ (#1855).

@PawelDmochowskiDRAST

This comment has been minimized.

PawelDmochowskiDRAST commented Jul 27, 2018

This change introduces triggering of input-event on model changes which is against the docs and is a breaking change since it is no longer possible to distinguish between a change via user interaction and change of underlying model.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 14, 2018

New version of form-input uses a custom event for updating the v-model, while preserving the input and change events (and not firing extras). PR #2100 addresses most of the issues, and a new PR will be making a few adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment