Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-group): Styling fix for dropdowns, radio and checkbox groups. Fixes #2114,#1560 #2118

Merged
merged 7 commits into from Oct 30, 2018

Conversation

Projects
None yet
1 participant
@tmorehouse
Copy link
Member

commented Oct 30, 2018

Description of PR:

Adds styling for b-dropdown, b-form-checkbox-group and b-form-radio-group when these components are placed inside a b-input-group or .input-group.

Fixes #2114,#1560


What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other: css styling update

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)

If new features/enhancement/fixes are added or changed:

  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users?)

tmorehouse added some commits Oct 30, 2018

@codecov

This comment has been minimized.

Copy link

commented Oct 30, 2018

Codecov Report

Merging #2118 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2118   +/-   ##
=======================================
  Coverage   64.77%   64.77%           
=======================================
  Files         156      156           
  Lines        2950     2950           
  Branches      811      811           
=======================================
  Hits         1911     1911           
  Misses        752      752           
  Partials      287      287
Impacted Files Coverage Δ
src/components/form-radio/form-radio-group.js 78.57% <ø> (ø) ⬆️
src/components/dropdown/dropdown.js 100% <ø> (ø) ⬆️
src/components/input-group/input-group.js 100% <ø> (ø) ⬆️
...rc/components/form-checkbox/form-checkbox-group.js 78.57% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3068aa1...69171c4. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(input-group): Styling fix for dropdowns, radio and checkbox groups. fixes #2114,#1560 fix(input-group): Styling fix for dropdowns, radio and checkbox groups. Fixes #2114,#1560 Oct 30, 2018

@tmorehouse tmorehouse merged commit ed31bcd into dev Oct 30, 2018

8 of 9 checks passed

License Compliance Analysis done, scanning for issues...
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-beta Your tests passed on CircleCI!
Details
ci/circleci: test-latest Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 3068aa1...69171c4
Details
codecov/project 64.77% remains the same compared to 3068aa1
Details
deploy/netlify Deploy preview ready!
Details

@tmorehouse tmorehouse deleted the tmorehouse/input-group-css branch Oct 30, 2018

@tmorehouse tmorehouse referenced this pull request Nov 14, 2018

Closed

Bootstrap-Vue V2.0.0-rc.12 Tracker #2173

81 of 89 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.