Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-input): support custom-range input + validation and input styles #2120

Merged
merged 45 commits into from Nov 1, 2018

Conversation

Projects
None yet
1 participant
@tmorehouse
Copy link
Member

commented Oct 30, 2018

Description of PR:

Support the Bootstrap V4.1 custom range input styles.

Adds in temporary CSS fixes until V4.2 is released
Adds in temporary CSS for validation and input-group support

fixes #2113

An issue has been created at twbs/bootstrap twbs/bootstrap#27572 requesting these be added


PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe: Custom CSS

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users?)

If adding a new feature, or changing the functionality of an existing feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

PR titles should following the Conventional Commits naming convention

tmorehouse added some commits Oct 30, 2018

@codecov

This comment has been minimized.

Copy link

commented Oct 30, 2018

Codecov Report

Merging #2120 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2120   +/-   ##
=======================================
  Coverage   64.77%   64.77%           
=======================================
  Files         156      156           
  Lines        2950     2950           
  Branches      811      811           
=======================================
  Hits         1911     1911           
  Misses        752      752           
  Partials      287      287
Impacted Files Coverage Δ
src/components/form-input/form-input.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba1230...6157670. Read the comment docs.

tmorehouse added some commits Oct 30, 2018

Delete form-input.css
Move type color and type range into separate css files
form-input.js comment out range css import temporarily
netlify deploy is starting to fail, while all other builds and tests are fine

@tmorehouse tmorehouse changed the title feat(input): support custom-range input styles. Fixes #2113 feat(form-input): support custom-range input styles. Fixes #2113 Oct 31, 2018

tmorehouse added some commits Oct 31, 2018

@tmorehouse tmorehouse requested a review from pi0 Oct 31, 2018

@tmorehouse tmorehouse changed the title feat(form-input): support custom-range input styles. Fixes #2113 feat(form-input): support custom-range input validation and input styles Oct 31, 2018

@tmorehouse tmorehouse changed the title feat(form-input): support custom-range input validation and input styles feat(form-input): support custom-range input + validation and input styles Oct 31, 2018

tmorehouse added some commits Oct 31, 2018

@tmorehouse

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

Example:
image

@tmorehouse tmorehouse merged commit 013a737 into dev Nov 1, 2018

9 checks passed

License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-beta Your tests passed on CircleCI!
Details
ci/circleci: test-latest Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 3ba1230...6157670
Details
codecov/project 64.77% remains the same compared to 3ba1230
Details
deploy/netlify Deploy preview ready!
Details

@tmorehouse tmorehouse referenced this pull request Nov 14, 2018

Closed

Bootstrap-Vue V2.0.0-rc.12 Tracker #2173

81 of 89 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.