Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-file): fix drag and drop feature #2169

Merged
merged 3 commits into from Nov 13, 2018

Conversation

Projects
None yet
1 participant
@tmorehouse
Copy link
Member

commented Nov 13, 2018

Description of Pull Request:

Adds missing handler registration, and adds optional drop placeholder.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
fix(form-file): fix drag and drop feature
adds missing handler registration, and adds optional drop placeholder.
@codecov

This comment has been minimized.

Copy link

commented Nov 13, 2018

Codecov Report

Merging #2169 into dev will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #2169      +/-   ##
=========================================
- Coverage   66.01%     66%   -0.02%     
=========================================
  Files         158     158              
  Lines        2998    3000       +2     
  Branches      832     833       +1     
=========================================
+ Hits         1979    1980       +1     
- Misses        739     740       +1     
  Partials      280     280
Impacted Files Coverage Δ
src/components/form-file/form-file.js 11.68% <50%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c26da...f056c30. Read the comment docs.

tmorehouse added some commits Nov 13, 2018

@tmorehouse tmorehouse merged commit 07bfc29 into dev Nov 13, 2018

6 of 9 checks passed

codecov/patch 50% of diff hit (target 66.01%)
Details
codecov/project 66% (-0.02%) compared to 56c26da
Details
License Compliance FOSSA is analyzing this commit
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-beta Your tests passed on CircleCI!
Details
ci/circleci: test-latest Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details

@tmorehouse tmorehouse deleted the tmorehouse/form-file branch Nov 13, 2018

@tmorehouse tmorehouse referenced this pull request Nov 14, 2018

Closed

Bootstrap-Vue V2.0.0-rc.12 Tracker #2173

81 of 89 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.