Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-input): Use new form-text mixin and add trim and number modifiers #2204

Merged
merged 11 commits into from Nov 21, 2018

Conversation

Projects
None yet
1 participant
@tmorehouse
Copy link
Member

commented Nov 21, 2018

Description of Pull Request:

Incorporates the new form-text mixin introduced with b-form-textarea PR #2111 which will help reduce the code footprint size, and introduces new number and trim modifier props.

  • test updates
  • doc updates
  • code update

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

tmorehouse added some commits Nov 21, 2018

Update form-textarea.js
minor update
@codecov

This comment has been minimized.

Copy link

commented Nov 21, 2018

Codecov Report

Merging #2204 into dev will decrease coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2204      +/-   ##
==========================================
- Coverage   66.51%   66.26%   -0.26%     
==========================================
  Files         159      159              
  Lines        3058     3035      -23     
  Branches      852      842      -10     
==========================================
- Hits         2034     2011      -23     
  Misses        744      744              
  Partials      280      280
Impacted Files Coverage Δ
src/components/form-textarea/form-textarea.js 90.9% <ø> (ø) ⬆️
src/mixins/form-text.js 80% <ø> (ø) ⬆️
src/components/form-input/form-input.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc4d226...77b9649. Read the comment docs.

tmorehouse added some commits Nov 21, 2018

@tmorehouse tmorehouse changed the title [WIP] feat(form-input): Use new form-text mixin and add trim and number modifiers feat(form-input): Use new form-text mixin and add trim and number modifiers Nov 21, 2018

@tmorehouse tmorehouse removed the Status: WIP label Nov 21, 2018

@tmorehouse tmorehouse referenced this pull request Nov 21, 2018

Closed

Bootstrap-Vue V2.0.0-rc.12 Tracker #2173

81 of 89 tasks complete

@tmorehouse tmorehouse merged commit 3c9936e into dev Nov 21, 2018

9 checks passed

License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-beta Your tests passed on CircleCI!
Details
ci/circleci: test-latest Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 66.51%)
Details
codecov/project Absolute coverage decreased by -0.25% but relative coverage increased by +33.48% compared to dc4d226
Details
deploy/netlify Deploy preview ready!
Details

@tmorehouse tmorehouse deleted the tmorehouse/form-input branch Nov 21, 2018

@jackmu95 jackmu95 referenced this pull request Feb 15, 2019

Merged

fix(form-input): Allow number as value type (Closes #2582) #2583

6 of 18 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.