Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add support for scrollable dialog content #2535

Merged
merged 3 commits into from Feb 12, 2019

Conversation

Projects
None yet
1 participant
@tmorehouse
Copy link
Member

commented Feb 12, 2019

Description of Pull Request:

Adds new prop scrollable to modal for enabling scrollable dialog content, when the dialog would be taller than the viewport.

New in Bootstrap V4.3

TO DO:

  • Documentation update

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)
feat(modal): add support for scrollable dialog content
Adds new prop `scrollable` to enable scrollable dialog content, when the dialog would be taller than the viewport.

New in Bootstrap V4.3
@codecov

This comment has been minimized.

Copy link

commented Feb 12, 2019

Codecov Report

Merging #2535 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2535   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files         172      172           
  Lines        3248     3248           
  Branches      917      917           
=======================================
  Hits         2321     2321           
  Misses        674      674           
  Partials      253      253
Impacted Files Coverage Δ
src/components/modal/modal.js 56.96% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b7e1e...d2995c9. Read the comment docs.

tmorehouse added some commits Feb 12, 2019

@tmorehouse tmorehouse removed the Status: WIP label Feb 12, 2019

@tmorehouse tmorehouse merged commit 5c01faf into dev Feb 12, 2019

9 checks passed

License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing c4b7e1e...d2995c9
Details
codecov/project 71.45% remains the same compared to c4b7e1e
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected

@tmorehouse tmorehouse deleted the tmorehouse/modal-scrollable branch Feb 12, 2019

@tmorehouse tmorehouse referenced this pull request Feb 12, 2019

Closed

Bootstrap-Vue V2.0.0-rc.12 Tracker #2173

81 of 89 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.