Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils/get): handle case where passed object is null (Fixes #2623) #2624

Merged
merged 2 commits into from Feb 18, 2019

Conversation

tmorehouse
Copy link
Member

Description of Pull Request:

Fixes an issue with the get method where the passed object is null or undefined.

Fixes #2623

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

…2623)


Fixes an issue with the `get` method where the passed object is null or undefined.

Fixes #2623
@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #2624 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2624   +/-   ##
=======================================
  Coverage   70.47%   70.47%           
=======================================
  Files         172      172           
  Lines        3170     3170           
  Branches      923      923           
=======================================
  Hits         2234     2234           
  Misses        680      680           
  Partials      256      256
Impacted Files Coverage Δ
src/utils/get.js 87.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56123f6...0d87a7b. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(utils/get): handle calse where passed object is undefined (Fixes #2623) fix(utils/get): handle calse where passed object is null (Fixes #2623) Feb 18, 2019
@tmorehouse tmorehouse merged commit eb07b19 into dev Feb 18, 2019
@tmorehouse tmorehouse changed the title fix(utils/get): handle calse where passed object is null (Fixes #2623) fix(utils/get): handle case where passed object is null (Fixes #2623) Feb 18, 2019
@tmorehouse tmorehouse deleted the tmorehouse/get-fix branch February 18, 2019 03:07
@tmorehouse tmorehouse mentioned this pull request Feb 18, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null Error Between 2.0.0-rc.11 and 2.0.0-rc.12 On Table Fields
2 participants