Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-textarea): add `noAutoShrink` prop (closes #2664) #2666

Merged
merged 17 commits into from Feb 23, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

tweak comments

  • Loading branch information...
jackmu95 committed Feb 22, 2019
commit 042ad78f0cc3bc1ea90dca5df9c2d2d768c1a8ef
@@ -116,10 +116,10 @@ export default {
// Calculate the required height of the textarea including border and padding (in pixels)
const height = Math.max(Math.ceil(rows * lineHeight + offset), minHeight)

// Place oldHight back on element, just in case this computed prop returns the same value
// Place old height back on element, just in case this computed prop returns the same value
el.style.height = oldHeight

// value of previous height (without px units appended)
// Value of previous height (without px units appended)
const oldHeightPx = parseFloat(oldHeight) || 0

if (!this.noAutoShrink && oldHeightPx > height) {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.