Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-input): allow number type for form-inputs (via form-text mixin) #2738

merged 12 commits into from Feb 28, 2019


None yet
1 participant
Copy link

commented Feb 28, 2019

Description of Pull Request:

Allows number type for b-form-input, to handle when using the number modifier prop. Prevents console warnings about prop type checks.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

This comment has been minimized.

Copy link

commented Feb 28, 2019

Codecov Report

Merging #2738 into dev will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2738      +/-   ##
+ Coverage   74.43%   74.67%   +0.23%     
  Files         173      173              
  Lines        3200     3198       -2     
  Branches      940      940              
+ Hits         2382     2388       +6     
+ Misses        599      593       -6     
+ Partials      219      217       -2
Impacted Files Coverage Δ
src/components/form-input/form-input.js 100% <ø> (ø) ⬆️
src/mixins/form-text.js 95.83% <100%> (+15.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285a2e1...172747d. Read the comment docs.

tmorehouse added some commits Feb 28, 2019

@tmorehouse tmorehouse referenced this pull request Feb 28, 2019


chore: release v2.0.0-rc.14 #2704

1 of 4 tasks complete

@tmorehouse tmorehouse changed the title fix(form-input): allow number type for string inputs fix(form-input): allow number type for form-inputs (via form-text mixin) Feb 28, 2019

@tmorehouse tmorehouse merged commit ec91788 into dev Feb 28, 2019

7 of 9 checks passed

License Compliance FOSSA is analyzing this commit
deploy/netlify Deploy preview processing.
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
codecov/patch 100% of diff hit (target 74.43%)
codecov/project 74.67% (+0.23%) compared to 285a2e1
security/snyk - package.json (pi0) No manifest changes detected

@tmorehouse tmorehouse deleted the tmorehouse/form-text branch Feb 28, 2019

@tmorehouse tmorehouse removed the Status: WIP label Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.