Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): remove deprecated `es/` build #3604

Merged
merged 222 commits into from Aug 13, 2019

Conversation

@tmorehouse
Copy link
Member

commented Jul 1, 2019

BREAKING CHANGE: removal of deprecated es/ build directory

Describe the PR

This PR is for the 2.0.0 stable release, to remove the deprecated es/ build

To do:

  • remove es/ build commands
  • docs update
  • remove legacy plugin exports and re-normalize components/index.js and directives/index.js files
  • remove legacy es entrypoint index
  • remove default exports from all component index.js files
  • remove default exports from all directive index.js files
  • move all component/directive/plugin re-exports to src/index.js
  • Release stable build

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) remove deprecated build

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

Users will no longer be able to import from the es/ build dirs. Users should be switching to the simplified import methods introduced in v2.0.0-rc.22. Legacy plugin names will no longer work as they were only exported from es/ build.

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added this to In Progress in 2.0.0 Stable via automation Jul 1, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 1, 2019

Codecov Report

Merging #3604 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #3604   +/-   ##
=====================================
  Coverage   99.3%   99.3%           
=====================================
  Files        233     233           
  Lines       4485    4485           
  Branches    1270    1270           
=====================================
  Hits        4454    4454           
  Misses        25      25           
  Partials       6       6
Impacted Files Coverage Δ
src/components/nav/index.js 100% <ø> (ø) ⬆️
src/components/alert/index.js 100% <ø> (ø) ⬆️
src/components/table/index.js 100% <ø> (ø) ⬆️
src/components/spinner/index.js 100% <ø> (ø) ⬆️
src/components/modal/index.js 100% <ø> (ø) ⬆️
src/components/form-select/index.js 100% <ø> (ø) ⬆️
src/components/toast/index.js 100% <ø> (ø) ⬆️
src/components/media/index.js 100% <ø> (ø) ⬆️
src/components/form-textarea/index.js 100% <ø> (ø) ⬆️
src/components/card/index.js 100% <ø> (ø) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1737072...27151d3. Read the comment docs.

tmorehouse and others added 4 commits Jul 1, 2019
docs/components/importdoc.vue Outdated Show resolved Hide resolved
docs/components/importdoc.vue Outdated Show resolved Hide resolved
jackmu95 and others added 19 commits Jul 1, 2019
tmorehouse added 14 commits Aug 12, 2019

@tmorehouse tmorehouse marked this pull request as ready for review Aug 12, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Aug 12, 2019

@jackmu95

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@tmorehouse Let's get this done first so we don't have to resolve conflicts all the time.

@tmorehouse

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

@jackmu95 yeah, that was my thinking as well. The conflicts were always a pain in the behind.

@tmorehouse tmorehouse merged commit 3828f59 into dev Aug 13, 2019

9 checks passed

License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.3%)
Details
codecov/project 99.3% (+0%) compared to 1737072
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected

2.0.0 Stable automation moved this from In Progress to Completed Aug 13, 2019

@tmorehouse tmorehouse deleted the no-es-build branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.