Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-table-simple): new `<table>` wrapper component that allows users to render their own `<thead>`, `<tfoot>`, `<body>` #3799

Merged
merged 27 commits into from Aug 2, 2019

Conversation

@tmorehouse
Copy link
Member

commented Aug 1, 2019

Describe the PR

Renders a table element (with optional basic styles), which renders the users content in the default slot.

Provides no items, sorting, etc. Just purely table styles (except stacked)

Requires users to place their own <thead>, <tfoot>, <tbody> etc in the default slot.

This provides users the flexibility to create row and col spans as needed

Uses some shared code with b-table, so the extra foot print of this component is very lightweight.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
feat(b-table-simple): new table component that allows users to render…
… their own `<thead>`, `<tfoot>` `<body>`

Renders a table element (with optional basic styles), which renders the users content in the default slot.

Provides no items, sorting, etc.  Just purely styles.

Requires users to place their own  `<thead>`, `<tfoot>`, `<tbody>` etc in the default slot.
@codecov

This comment has been minimized.

Copy link

commented Aug 1, 2019

Codecov Report

Merging #3799 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3799      +/-   ##
==========================================
+ Coverage   99.29%   99.29%   +<.01%     
==========================================
  Files         224      226       +2     
  Lines        4391     4401      +10     
  Branches     1244     1251       +7     
==========================================
+ Hits         4360     4370      +10     
  Misses         25       25              
  Partials        6        6
Impacted Files Coverage Δ
src/components/index.esm.js 100% <ø> (ø) ⬆️
...c/components/table/helpers/default-sort-compare.js 100% <ø> (ø) ⬆️
src/components/table/index.js 100% <ø> (ø) ⬆️
src/components/table/table.js 100% <ø> (ø) ⬆️
src/components/table/helpers/mixin-busy.js 100% <ø> (ø) ⬆️
src/components/table/helpers/constants.js 100% <ø> (ø) ⬆️
src/components/table/table-lite.js 100% <ø> (ø) ⬆️
src/components/table/helpers/mixin-caption.js 100% <ø> (ø) ⬆️
...c/components/table/helpers/mixin-table-renderer.js 100% <100%> (ø) ⬆️
src/components/table/helpers/mixin-stacked.js 100% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0a5a6...d65b5ee. Read the comment docs.

tmorehouse added some commits Aug 1, 2019

@tmorehouse tmorehouse changed the title feat(b-table-simple): new table component that allows users to rendertheir own `<thead>`, `<tfoot>`, `<body>` feat(b-table-simple): new table component that allows users to render their own `<thead>`, `<tfoot>`, `<body>` Aug 1, 2019

tmorehouse added some commits Aug 1, 2019

@tmorehouse tmorehouse removed the Status: WIP label Aug 1, 2019

@tmorehouse tmorehouse marked this pull request as ready for review Aug 1, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Aug 1, 2019

@tmorehouse tmorehouse changed the title feat(b-table-simple): new table component that allows users to render their own `<thead>`, `<tfoot>`, `<body>` feat(b-table-simple): new `<table>` wrapper component that allows users to render their own `<thead>`, `<tfoot>`, `<body>` Aug 1, 2019

tmorehouse added some commits Aug 1, 2019

tmorehouse added some commits Aug 1, 2019

@tmorehouse tmorehouse merged commit 998bd4f into dev Aug 2, 2019

9 checks passed

License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.29%)
Details
codecov/project 99.29% (+<.01%) compared to 7a0a5a6
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected

@tmorehouse tmorehouse deleted the tmorehouse/table-simple branch Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.