Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): defaults for all `size` properties (closes #3805) #3841

Merged
merged 15 commits into from Aug 8, 2019

Conversation

@jackmu95
Copy link
Member

commented Aug 8, 2019

Describe the PR

This PR adds size config properties for all components.

Closes #3805.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov

This comment has been minimized.

Copy link

commented Aug 8, 2019

Codecov Report

Merging #3841 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             dev   #3841      +/-   ##
========================================
+ Coverage   99.3%   99.3%   +<.01%     
========================================
  Files        233     233              
  Lines       4440    4452      +12     
  Branches    1262    1262              
========================================
+ Hits        4409    4421      +12     
  Misses        25      25              
  Partials       6       6
Impacted Files Coverage Δ
src/mixins/pagination.js 100% <100%> (ø) ⬆️
src/components/button-group/button-group.js 100% <100%> (ø) ⬆️
src/components/form-file/form-file.js 95.91% <100%> (+0.08%) ⬆️
src/components/dropdown/dropdown.js 100% <100%> (ø) ⬆️
src/components/pagination-nav/pagination-nav.js 100% <100%> (ø) ⬆️
src/components/pagination/pagination.js 100% <100%> (ø) ⬆️
src/components/button/button.js 100% <100%> (ø) ⬆️
src/mixins/form-size.js 100% <100%> (ø) ⬆️
src/components/input-group/input-group.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b02fb49...71fdd10. Read the comment docs.

Show resolved Hide resolved src/utils/config-defaults.js Outdated

jackmu95 added some commits Aug 8, 2019

Show resolved Hide resolved src/utils/config-defaults.js Outdated

@jackmu95 jackmu95 requested a review from tmorehouse Aug 8, 2019

jackmu95 added some commits Aug 8, 2019

@jackmu95 jackmu95 requested a review from tmorehouse Aug 8, 2019

tmorehouse and others added some commits Aug 8, 2019

Show resolved Hide resolved src/mixins/form-size.js Outdated

jackmu95 and others added some commits Aug 8, 2019

@tmorehouse tmorehouse self-requested a review Aug 8, 2019

@jackmu95 jackmu95 merged commit 1389efa into dev Aug 8, 2019

8 of 9 checks passed

License Compliance FOSSA is analyzing this commit
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.3%)
Details
codecov/project 99.3% (+<.01%) compared to b02fb49
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected

@jackmu95 jackmu95 deleted the feat-config-size branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.