Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): remove deprecations #3863

merged 4 commits into from Aug 13, 2019


Copy link

commented Aug 13, 2019

Describe the PR

This PR removes the deprecations from the <b-tabs> and <b-tab> components.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@jackmu95 jackmu95 requested a review from tmorehouse Aug 13, 2019

@jackmu95 jackmu95 added this to In Progress in 2.0.0 Stable via automation Aug 13, 2019


This comment has been minimized.

Copy link

commented Aug 13, 2019

Codecov Report

Merging #3863 into dev will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #3863      +/-   ##
+ Coverage   99.3%   99.32%   +0.02%     
  Files        233      233              
  Lines       4473     4469       -4     
  Branches    1266     1264       -2     
- Hits        4442     4439       -3     
+ Misses        25       24       -1     
  Partials       6        6
Impacted Files Coverage Δ
src/components/tabs/tab.js 100% <ø> (+2.85%) ⬆️
src/components/tabs/tabs.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249efd9...d8cc3d0. Read the comment docs.

tmorehouse and others added 3 commits Aug 13, 2019

@tmorehouse tmorehouse merged commit 0edac49 into dev Aug 13, 2019

8 of 9 checks passed

License Compliance FOSSA is analyzing this commit
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
codecov/patch Coverage not affected when comparing 249efd9...d8cc3d0
codecov/project 99.32% (+0.02%) compared to 249efd9
deploy/netlify Deploy preview ready!
security/snyk - package.json (pi0) No manifest changes detected

2.0.0 Stable automation moved this from In Progress to Completed Aug 13, 2019

@tmorehouse tmorehouse deleted the feat-tabs-remove-deprecations branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.