Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): remove deprecated slot names, introduce new slot names #3866

Merged
merged 34 commits into from Aug 13, 2019

Conversation

@jackmu95
Copy link
Member

commented Aug 13, 2019

Describe the PR

This PR removes the deprecations from the <b-table> and <b-table-simple> components.

Users should now be using slots cell[field] instead of field, head[field] instead of HEAD_field, and foot[field] instead of FOOT_field. Noe these new slot names are different than teh ones introduced in 2.0.0-rc.28.

The changes are needed due to the new Vue v-slot syntax

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@jackmu95 jackmu95 requested a review from tmorehouse Aug 13, 2019

@jackmu95 jackmu95 added this to In Progress in 2.0.0 Stable via automation Aug 13, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 13, 2019

Codecov Report

Merging #3866 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             dev   #3866      +/-   ##
========================================
- Coverage   99.3%   99.3%   -0.01%     
========================================
  Files        233     233              
  Lines       4484    4473      -11     
  Branches    1270    1266       -4     
========================================
- Hits        4453    4442      -11     
  Misses        25      25              
  Partials       6       6
Impacted Files Coverage Δ
src/components/table/helpers/normalize-fields.js 100% <ø> (ø) ⬆️
src/components/table/helpers/mixin-items.js 100% <ø> (ø) ⬆️
src/components/table/helpers/mixin-thead.js 100% <100%> (ø) ⬆️
src/components/table/helpers/mixin-tbody-row.js 100% <100%> (ø) ⬆️
src/components/table/helpers/mixin-filtering.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29eb8b1...cb1b10c. Read the comment docs.

tmorehouse added some commits Aug 13, 2019

tmorehouse added some commits Aug 13, 2019

tmorehouse added some commits Aug 13, 2019

@tmorehouse tmorehouse changed the title feat(table): remove deprecations feat(table): remove deprecated slot names Aug 13, 2019

tmorehouse added some commits Aug 13, 2019

@tmorehouse

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Created an upstream issue at vuejs/vue#10390 regarding new v-slot syntax not working with slot names that start with [

@tmorehouse tmorehouse merged commit 249efd9 into dev Aug 13, 2019

7 of 8 checks passed

License Compliance FOSSA is analyzing this commit
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.3%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.69% compared to 29eb8b1
Details
deploy/netlify Deploy preview ready!
Details

2.0.0 Stable automation moved this from In Progress to Completed Aug 13, 2019

@tmorehouse tmorehouse deleted the feat-table-remove-deprecations branch Aug 13, 2019

@tmorehouse tmorehouse changed the title feat(table): remove deprecated slot names feat(table): remove deprecated slot names, introduce new slot names Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.