Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): remove deprecated slot names, introduce new slot names #3866

Merged
merged 34 commits into from Aug 13, 2019
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
6003d39
feat(table): remove deprecations
jackmu95 Aug 13, 2019
ed91ac2
Update nav.spec.js
jackmu95 Aug 13, 2019
fe2e048
Update mixin-filtering.js
jackmu95 Aug 13, 2019
e6f7f81
Update normalize-fields.spec.js
tmorehouse Aug 13, 2019
db7fa23
Update normalize-fields.spec.js
tmorehouse Aug 13, 2019
30d2810
Update normalize-fields.spec.js
tmorehouse Aug 13, 2019
8c13351
lint
tmorehouse Aug 13, 2019
37a6af7
make sure footer falls back to HEAD slots if FOOT slots not provided
tmorehouse Aug 13, 2019
5d76cda
lint
tmorehouse Aug 13, 2019
3e4a983
Update README.md
tmorehouse Aug 13, 2019
a6a2a83
Update mixin-thead.js
tmorehouse Aug 13, 2019
762ffd7
Update README.md
tmorehouse Aug 13, 2019
1e235da
Merge branch 'dev' into feat-table-remove-deprecations
tmorehouse Aug 13, 2019
5489b17
Update package.json
tmorehouse Aug 13, 2019
b5bc12e
Update package.json
tmorehouse Aug 13, 2019
14bebd0
Update package.json
tmorehouse Aug 13, 2019
b68dd4e
Update mixin-tbody-row.js
tmorehouse Aug 13, 2019
d562318
Update package.json
tmorehouse Aug 13, 2019
1cc80f5
Update table-row-details.spec.js
tmorehouse Aug 13, 2019
1291a05
Update table-tbody-row-events.spec.js
tmorehouse Aug 13, 2019
117d615
Update table-tfoot-events.spec.js
tmorehouse Aug 13, 2019
2af809c
Update table-thead-events.spec.js
tmorehouse Aug 13, 2019
21f7812
Update README.md
tmorehouse Aug 13, 2019
c4f819c
Update mixin-tbody-row.js
tmorehouse Aug 13, 2019
9ad0c46
Update mixin-tbody-row.js
tmorehouse Aug 13, 2019
bd786e7
Update mixin-thead.js
tmorehouse Aug 13, 2019
d810414
Update mixin-tbody-row.js
tmorehouse Aug 13, 2019
1564de8
Update mixin-thead.js
tmorehouse Aug 13, 2019
b8fd0bf
Update table-tbody-row-events.spec.js
tmorehouse Aug 13, 2019
c6a623b
Update mixin-tbody-row.js
tmorehouse Aug 13, 2019
d2af57a
Update componentdoc.vue
tmorehouse Aug 13, 2019
f47d93b
Update importdoc.vue
tmorehouse Aug 13, 2019
2821515
Update README.md
tmorehouse Aug 13, 2019
cb1b10c
Update README.md
tmorehouse Aug 13, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Update mixin-thead.js

  • Loading branch information...
tmorehouse committed Aug 13, 2019
commit a6a2a833ab0e5124dc3230cc7001bc4115e5b77a
@@ -99,10 +99,24 @@ export default {
},
on: handlers
}
let slotNames = [`HEAD[${field.key}]`, 'HEAD[]']
// Handle edge case where in-document templates are used with new
// `v-slot:name` syntax where the browser lower-cases the v-slot's
// name (attributes become lower cased when parsed by the browser)
let slotNames = [
`HEAD[${field.key}]`,
`head[${field.key.toLowerCase()}]`,
'HEAD[]',
'head[]'
]
if (isFoot) {
// Footer will fallback to header slot names
slotNames = [`FOOT[${field.key}]`, 'FOOT[]', ...slotNames]
slotNames = [
`FOOT[${field.key}]`,
`foot[${field.key.toLowerCase()}]`,
'FOOT[]',
'foot[]',
...slotNames
]
}
const slot = this.normalizeSlot(slotNames, {
label: field.label,
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.