Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tables): add support for custom header attributes (closes #2244) #3876

merged 8 commits into from Aug 14, 2019


Copy link

@jonfunkhouser jonfunkhouser commented Aug 13, 2019

Describe the PR

Adds thAttr to the field definition. This allows for dynamic attributes per <th>.

Closes #2244

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

src/components/table/ Outdated Show resolved Hide resolved
Copy link

@codecov codecov bot commented Aug 13, 2019

Codecov Report

Merging #3876 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3876      +/-   ##
+ Coverage   99.32%   99.33%   +<.01%     
  Files         233      233              
  Lines        4469     4478       +9     
  Branches     1264     1267       +3     
+ Hits         4439     4448       +9     
  Misses         24       24              
  Partials        6        6
Impacted Files Coverage Δ
src/components/table/helpers/mixin-thead.js 100% <ø> (ø) ⬆️
src/components/table/helpers/mixin-tbody-row.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0edac49...1a7b652. Read the comment docs.

@tmorehouse tmorehouse requested a review from jacobmllr95 Aug 13, 2019
@jacobmllr95 jacobmllr95 requested a review from tmorehouse Aug 14, 2019
@jacobmllr95 jacobmllr95 merged commit 8784f31 into bootstrap-vue:dev Aug 14, 2019
8 checks passed
Copy link

@jacobmllr95 jacobmllr95 commented Aug 14, 2019

Thanks @jonfunkhouser!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

3 participants