Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-nav): add card header support #3883

merged 14 commits into from Aug 14, 2019


Copy link

commented Aug 14, 2019

Describe the PR

Adds in support for placing b-nav in card headers via a new card-header boolean prop. When placing in cards, the consumer must wrap in a <b-card-header> or place in the <b-card> slot header.

Has no effect if the nav has the vertical prop set.

Automatically applies the correct classes for pills and tabs mode

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
feat(b-nav): add card header support
Adds in support for placing  `b-nav` in card headers via a new `card-header` boolean prop.

Automatically applies the correct classes for pills and tabs mode

@tmorehouse tmorehouse added this to In Progress in 2.0.0 Stable via automation Aug 14, 2019


This comment has been minimized.

Copy link

commented Aug 14, 2019

Codecov Report

Merging #3883 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3883      +/-   ##
- Coverage   99.32%   99.32%   -0.01%     
  Files         233      233              
  Lines        4470     4467       -3     
  Branches     1265     1263       -2     
- Hits         4440     4437       -3     
  Misses         24       24              
  Partials        6        6
Impacted Files Coverage Δ
src/components/nav/nav.js 100% <ø> (ø) ⬆️
src/components/tabs/tabs.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8b7aa...cade7ec. Read the comment docs.

tmorehouse added 7 commits Aug 14, 2019

@tmorehouse tmorehouse removed the Status: WIP label Aug 14, 2019

@tmorehouse tmorehouse marked this pull request as ready for review Aug 14, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Aug 14, 2019

jackmu95 and others added 4 commits Aug 14, 2019

@tmorehouse tmorehouse merged commit 4046a53 into dev Aug 14, 2019

9 checks passed

License Compliance All checks passed.
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
codecov/patch 100% of diff hit (target 99.32%)
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.67% compared to 8f8b7aa
deploy/netlify Deploy preview ready!
security/snyk - package.json (pi0) No manifest changes detected

2.0.0 Stable automation moved this from In Progress to Completed Aug 14, 2019

@tmorehouse tmorehouse deleted the tmorehouse/nav-cards branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.