Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-modal): ensure non-prop attributes are transferred to the modal outer wrapper `div` (closes #3896) #3921

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@tmorehouse
Copy link
Member

commented Aug 20, 2019

Describe the PR

When the modal was not in static mode, any additional attributes were not rendering on the modal wrapper div (instead they were being applied to the BTransporter component)

This PR ensures that the attributes are always transferred to the wrapper DIV.

Closes #3896.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse changed the title fix(b-modal): ensure attributes are transferred to the modal outer wrapper div fix(b-modal): ensure non-prop attributes are transferred to the modal outer wrapper `div` Aug 20, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Aug 20, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 20, 2019

Codecov Report

Merging #3921 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3921   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files         233      233           
  Lines        4495     4495           
  Branches     1271     1271           
=======================================
  Hits         4465     4465           
  Misses         24       24           
  Partials        6        6
Impacted Files Coverage Δ
src/components/modal/modal.js 99.57% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a392059...93d9319. Read the comment docs.

@jackmu95 jackmu95 changed the title fix(b-modal): ensure non-prop attributes are transferred to the modal outer wrapper `div` fix(b-modal): ensure non-prop attributes are transferred to the modal outer wrapper `div` (closes #3896) Aug 21, 2019

@jackmu95 jackmu95 merged commit 8bf3a55 into dev Aug 21, 2019

9 checks passed

License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a392059...93d9319
Details
codecov/project 99.33% remains the same compared to a392059
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected

@jackmu95 jackmu95 deleted the tmorehouse/modal-attrs branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.