Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-form-textarea): handle initial auto-height when in modal, tabs, or other component with transition or which uses `v-show` (fixes #3936, #3702) #3937

Merged
merged 37 commits into from Aug 26, 2019

Conversation

@tmorehouse
Copy link
Member

commented Aug 23, 2019

Describe the PR

Incorporates IntersectionObserver for visibility checks and runs the height computation when the textarea becomes visible. Useful when the component is inside a non-lazy modal or b-tab component. Handles situations where the textarea is hidden via display: none (i.e. v-show)

Fixes issues with the initial auto-resize when placed inside modals, b-tabs, etc, or an element/component that has the directive v-show on it.

The visibility observer is implemented as a private directive. The directive does nothing if IntersectinObserver is not available (either natively or via polyfill). IE11 requires a polyfill for IntersectinObserver.

Fixes #3936
Fixes #3702

Future (after merging): update the following components to use the new private visibility directive:

  • b-img-lazy (to determine when image is in viewport),
  • b-carousel (for pausing cycling when not visible),
  • form-* controls which have the autofocus prop

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
fix(b-form-textarea): handle initial auto height when in modal or oth…
…er component with transition delays (closes #3936)
@codecov

This comment has been minimized.

Copy link

commented Aug 23, 2019

Codecov Report

Merging #3937 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3937      +/-   ##
==========================================
+ Coverage   99.33%   99.33%   +<.01%     
==========================================
  Files         233      234       +1     
  Lines        4494     4526      +32     
  Branches     1269     1275       +6     
==========================================
+ Hits         4464     4496      +32     
  Misses         24       24              
  Partials        6        6
Impacted Files Coverage Δ
src/components/form-textarea/form-textarea.js 100% <100%> (ø) ⬆️
src/directives/visible.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a3b350...7e44d12. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(b-form-textarea): handle initial auto height when in modal or other component with transition delays (closes #3936) fix(b-form-textarea): handle initial auto height when in modal or other component with transition delays (fixes #3936) Aug 23, 2019

tmorehouse added 10 commits Aug 23, 2019
tmorehouse added 9 commits Aug 24, 2019

@tmorehouse tmorehouse removed the Status: WIP label Aug 24, 2019

@tmorehouse tmorehouse changed the title fix(b-form-textarea): handle initial auto height when in modal or other component with transition delays (fixes #3936) fix(b-form-textarea): handle initial auto-height when in modal or other component with transition delays or use of `v-show` (fixes #3936) Aug 24, 2019

@tmorehouse tmorehouse marked this pull request as ready for review Aug 24, 2019

@tmorehouse tmorehouse changed the title fix(b-form-textarea): handle initial auto-height when in modal or other component with transition delays or use of `v-show` (fixes #3936) fix(b-form-textarea): handle initial auto-height when in modal or other component with transition or use of `v-show` (fixes #3936) Aug 24, 2019

@tmorehouse tmorehouse changed the title fix(b-form-textarea): handle initial auto-height when in modal or other component with transition or use of `v-show` (fixes #3936) fix(b-form-textarea): handle initial auto-height when in modal or other component with transition or use of `v-show` (fixes #3936, #3702) Aug 24, 2019

@tmorehouse tmorehouse changed the title fix(b-form-textarea): handle initial auto-height when in modal or other component with transition or use of `v-show` (fixes #3936, #3702) fix(b-form-textarea): handle initial auto-height when in modal, tabs, or other component with transition or use of `v-show` (fixes #3936, #3702) Aug 24, 2019

@tmorehouse tmorehouse changed the title fix(b-form-textarea): handle initial auto-height when in modal, tabs, or other component with transition or use of `v-show` (fixes #3936, #3702) fix(b-form-textarea): handle initial auto-height when in modal, tabs, or other component with transition or uses `v-show` (fixes #3936, #3702) Aug 24, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Aug 24, 2019

@tmorehouse tmorehouse added this to In Progress in 2.0.0 Stable via automation Aug 24, 2019

@tmorehouse tmorehouse changed the title fix(b-form-textarea): handle initial auto-height when in modal, tabs, or other component with transition or uses `v-show` (fixes #3936, #3702) fix(b-form-textarea): handle initial auto-height when in modal, tabs, or other component with transition or which uses `v-show` (fixes #3936, #3702) Aug 24, 2019

tmorehouse and others added 3 commits Aug 24, 2019
tmorehouse added 3 commits Aug 25, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Aug 25, 2019

tmorehouse and others added 7 commits Aug 25, 2019

@tmorehouse tmorehouse merged commit be3ac62 into dev Aug 26, 2019

7 of 8 checks passed

License Compliance FOSSA is analyzing this commit
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.33%)
Details
codecov/project 99.33% (+<.01%) compared to 7a3b350
Details
security/snyk - package.json (pi0) No manifest changes detected

2.0.0 Stable automation moved this from In Progress to Completed Aug 26, 2019

@tmorehouse tmorehouse deleted the issue/3936 branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.