Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-table): new sorting icons using SVG, plus option to place icon on left of header cell (closes #3687, #3696, #3918, #3966) #3968

Merged
merged 34 commits into from Aug 29, 2019

Conversation

@tmorehouse
Copy link
Member

commented Aug 28, 2019

Describe the PR

Replaces the sort icons with SVG backgrounds

New Boolean prop sort-icon-left to place the icons on the left side of the header cell instead of the default of right.

Closes #3687
Closes #3696
Closes #3918
Closes #3966

Removed SASS variables:

  • $b-table-sort-icon-null
  • $b-table-sort-icon-ascending
  • $b-table-sort-icon-descending
  • $b-table-sort-icon-margin-left
  • $b-table-sort-icon-width

New SASS variables:

  • $b-table-sort-icon-bg-width
  • $b-table-sort-icon-bg-height
  • $b-table-sort-icon-bg-not-sorted
  • $b-table-sort-icon-bg-descending
  • $b-table-sort-icon-bg-ascending
  • $b-table-sort-icon-bg-dark-not-sorted (for dark mode tables)
  • $b-table-sort-icon-bg-dark-descending (for dark mode tables)
  • $b-table-sort-icon-bg-dark-ascending (for dark mode tables)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) SCSS update

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

Old SCSS variables for icons (character based) have removed and replaced with SVG background icons. Users can config new icons using CSS variables (either data URI's or full URLs)

The breaking change in SCSS does not affect usability of sorting, just the customization of the sort icons

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov

This comment has been minimized.

Copy link

commented Aug 28, 2019

Codecov Report

Merging #3968 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3968   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         238      238           
  Lines        4465     4465           
  Branches     1253     1253           
=======================================
  Hits         4459     4459           
  Misses          5        5           
  Partials        1        1
Impacted Files Coverage Δ
src/components/table/helpers/mixin-sorting.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee13491...fbbd8b1. Read the comment docs.

tmorehouse added 4 commits Aug 28, 2019
tmorehouse added 18 commits Aug 28, 2019
tmorehouse added 3 commits Aug 29, 2019

@tmorehouse tmorehouse removed the Status: WIP label Aug 29, 2019

@tmorehouse tmorehouse marked this pull request as ready for review Aug 29, 2019

@tmorehouse tmorehouse added this to In Progress in 2.0.0 Stable via automation Aug 29, 2019

@tmorehouse tmorehouse changed the title feat(b-table): new sorting icons using SVG, plus option to place icon on left of header cell (closes #3696, #3966) feat(b-table): new sorting icons using SVG, plus option to place icon on left of header cell (closes #3696, #3918, #3966) Aug 29, 2019

@tmorehouse tmorehouse changed the title feat(b-table): new sorting icons using SVG, plus option to place icon on left of header cell (closes #3696, #3918, #3966) feat(b-table): new sorting icons using SVG, plus option to place icon on left of header cell (closes #3687, #3696, #3918, #3966) Aug 29, 2019

tmorehouse added 2 commits Aug 29, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Aug 29, 2019

jackmu95 added 3 commits Aug 29, 2019
tmorehouse added 2 commits Aug 29, 2019

@tmorehouse tmorehouse merged commit c4442f4 into dev Aug 29, 2019

8 of 9 checks passed

License Compliance FOSSA is analyzing this commit
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing ee13491...fbbd8b1
Details
codecov/project 99.86% remains the same compared to ee13491
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected

2.0.0 Stable automation moved this from In Progress to Completed Aug 29, 2019

@tmorehouse tmorehouse deleted the tmorehouse/table-sort-icons branch Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.