Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-link): only add the `nativeOn` property to componentData when rendering a router link #3976

merged 214 commits into from Aug 29, 2019


Copy link

commented Aug 29, 2019

Describe the PR

The latest version of Vue (2.6.10 when using DevTools) barfs out warnings if the data object property nativeOn (even when it is an empty object) appears on native elements.

This PR conditionally creates the nativeOn/on componentData properties based on the type of root element being rendered.

Issue was brought up on Discord chat.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
tmorehouse added 30 commits Aug 29, 2019
chore: remove default export from directives and components
All components and directives are now accessed by named exports, so the default exports can be removed

Will reduce bundle size slightly
tmorehouse added 16 commits Aug 29, 2019

@tmorehouse tmorehouse added this to In Progress in 2.0.0 Stable via automation Aug 29, 2019


This comment has been minimized.

Copy link

commented Aug 29, 2019

Codecov Report

Merging #3976 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3976   +/-   ##
  Coverage   99.86%   99.86%           
  Files         238      238           
  Lines        4466     4466           
  Branches     1253     1254    +1     
  Hits         4460     4460           
  Misses          5        5           
  Partials        1        1
Impacted Files Coverage Δ
src/components/link/link.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ec2a1...cd8b698. Read the comment docs.

@tmorehouse tmorehouse changed the title chore(b-link): only add the `nativeOn` property to componentData when rendering a router link fix(b-link): only add the `nativeOn` property to componentData when rendering a router link Aug 29, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Aug 29, 2019

@tmorehouse tmorehouse changed the base branch from tmorehouse/no-default-exports to dev Aug 29, 2019

@tmorehouse tmorehouse merged commit 62fb0b6 into dev Aug 29, 2019

9 checks passed

License Compliance All checks passed.
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
codecov/patch 100% of diff hit (target 99.86%)
codecov/project 99.86% (+0%) compared to f3ec2a1
deploy/netlify Deploy preview ready!
security/snyk - package.json (pi0) No manifest changes detected

2.0.0 Stable automation moved this from In Progress to Completed Aug 29, 2019

@tmorehouse tmorehouse deleted the tmorehouse/b-link-native-on branch Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.