Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add prop for auto focusing one of the built in-buttons once `shown` (closes #3945) #3979

Merged
merged 20 commits into from Aug 30, 2019

Conversation

@tmorehouse
Copy link
Member

commented Aug 30, 2019

Describe the PR

Adds a new prop auto-focus-button which accepts a string value of 'ok', 'cancel', or 'close', which will auto-focus one of the respective built in buttons (if present).

Falls back to focusing the modal content container (default action) if not set, or the button is not found.

Works with modal message boxes as well.

Closes #3945
Replaces #3542

To Do:

  • Updated tests
  • Documentation update

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov

This comment has been minimized.

Copy link

commented Aug 30, 2019

Codecov Report

Merging #3979 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3979      +/-   ##
==========================================
+ Coverage   99.86%   99.86%   +<.01%     
==========================================
  Files         238      238              
  Lines        4442     4449       +7     
  Branches     1248     1250       +2     
==========================================
+ Hits         4436     4443       +7     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
src/components/modal/modal.js 99.59% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7418f08...b5e875c. Read the comment docs.

@tmorehouse tmorehouse added this to In Progress in 2.0.0 Stable via automation Aug 30, 2019

tmorehouse added 12 commits Aug 30, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Aug 30, 2019

@tmorehouse tmorehouse removed the Status: WIP label Aug 30, 2019

@tmorehouse tmorehouse marked this pull request as ready for review Aug 30, 2019

@tmorehouse tmorehouse changed the title feat(modal): add prop for auto focusing one of the built in buttons on `shown` (closes #3945) feat(modal): add prop for auto focusing one of the built in-buttons on `shown` (closes #3945) Aug 30, 2019

@tmorehouse tmorehouse changed the title feat(modal): add prop for auto focusing one of the built in-buttons on `shown` (closes #3945) feat(modal): add prop for auto focusing one of the built in-buttons once `shown` (closes #3945) Aug 30, 2019

jackmu95 added 2 commits Aug 30, 2019
jackmu95 added 2 commits Aug 30, 2019

@jackmu95 jackmu95 merged commit 6f2827e into dev Aug 30, 2019

9 checks passed

License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.86%)
Details
codecov/project 99.86% (+<.01%) compared to 7418f08
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected

2.0.0 Stable automation moved this from In Progress to Completed Aug 30, 2019

@jackmu95 jackmu95 deleted the tmorehouse/modal-focus branch Aug 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.