Repository navigation
feat(b-table, b-table-lite): use aria-details rather than aria-describedby when details row showing (addresses #3801) - #3992
Merged
Conversation
…cribedby` when details row showing
Codecov Report
@@ Coverage Diff @@
## dev #3992 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 238 238
Lines 4453 4453
Branches 1252 1252
=======================================
Hits 4447 4447
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
tmorehouse
marked this pull request as ready for review
August 31, 2019 07:24
aria-details rather than aria-describedby when details row showingaria-details rather than aria-describedby when details row showing (addresses #3801)
jacobmllr95
approved these changes
Aug 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Changed from attribute
aria-describedbytoaria-detailswhen a row has details showing.aria-describedbyis read out by screen readers as a flattened string of the text content (which may not always make sense with complex markup such as sub tables).aria-detailsis similar, but just informs the user that there is a landmark region with additional details that they user can navigate to.Addresses part of #3801
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples, fix typos,chore: fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages.If new features/enhancement/fixes are added or changed:
package.jsonfor slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: