Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(b-table): cache cell slot names each render cycle (addresses #4008) #4011

Merged
merged 9 commits into from Sep 4, 2019

Conversation

@tmorehouse
Copy link
Member

commented Sep 3, 2019

Describe the PR

Will help improve performance (slightly) by not having to compute the possible slot names for each row rendered.

The cell slot names will only be looked-up once each render cycle.

Uses a non-reactive property on the table instance to store the cache.

Closes #4008 (partially)

Performance is still slow when table has 1000+ rows displayed, but is slightly improved.

User should be presenting paginated data (e.g. 100 rows at a time) rather than generating 1000 rows on screen.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) performance

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov

This comment has been minimized.

Copy link

commented Sep 3, 2019

Codecov Report

Merging #4011 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4011      +/-   ##
==========================================
+ Coverage   99.86%   99.86%   +<.01%     
==========================================
  Files         238      238              
  Lines        4454     4462       +8     
  Branches     1252     1254       +2     
==========================================
+ Hits         4448     4456       +8     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
src/components/table/helpers/mixin-tbody-row.js 100% <100%> (ø) ⬆️
src/components/table/helpers/mixin-tbody.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5855330...b9d202a. Read the comment docs.

tmorehouse added 5 commits Sep 3, 2019

@tmorehouse tmorehouse changed the title perf(b-table): cache cell slot names each render perf(b-table): cache cell slot names each render (addresses #4008) Sep 3, 2019

@tmorehouse tmorehouse removed the Status: WIP label Sep 3, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Sep 3, 2019

@tmorehouse tmorehouse marked this pull request as ready for review Sep 3, 2019

@tmorehouse tmorehouse added this to In Progress in 2.0.0 Stable via automation Sep 3, 2019

@tmorehouse tmorehouse changed the title perf(b-table): cache cell slot names each render (addresses #4008) perf(b-table): cache cell slot names each render cycle (addresses #4008) Sep 3, 2019

tmorehouse added 2 commits Sep 4, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Sep 4, 2019

@tmorehouse tmorehouse merged commit 78c604c into dev Sep 4, 2019

9 checks passed

License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.86%)
Details
codecov/project 99.86% (+<.01%) compared to 5855330
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected

2.0.0 Stable automation moved this from In Progress to Completed Sep 4, 2019

@tmorehouse tmorehouse deleted the tmorehouse/table-cache branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.