Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
perf(b-table): cache cell slot names each render cycle (addresses #4008) #4011
Describe the PR
Will help improve performance (slightly) by not having to compute the possible slot names for each row rendered.
The cell slot names will only be looked-up once each render cycle.
Uses a non-reactive property on the table instance to store the cache.
Closes #4008 (partially)
Performance is still slow when table has 1000+ rows displayed, but is slightly improved.
User should be presenting paginated data (e.g. 100 rows at a time) rather than generating 1000 rows on screen.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
@@ Coverage Diff @@ ## dev #4011 +/- ## ========================================== + Coverage 99.86% 99.86% +<.01% ========================================== Files 238 238 Lines 4454 4462 +8 Branches 1252 1254 +2 ========================================== + Hits 4448 4456 +8 Misses 5 5 Partials 1 1