Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-dropdown-*): ensure class bindings are placed on root element for all dropdown sub-components (closes #4022) #4024

merged 9 commits into from Sep 5, 2019


Copy link

@tmorehouse tmorehouse commented Sep 5, 2019

Describe the PR

Makes all dropdown sub-components behave the same as <b-drodpown-item> and <b-dropdown-item-button> when it comes to class bindings being placed on sub-component's root element

Non prop attributes are transferred to the inner element

Closes #4022

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added this to In Progress in 2.0.0 Stable via automation Sep 5, 2019
Copy link

@codecov codecov bot commented Sep 5, 2019

Codecov Report

Merging #4024 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4024      +/-   ##
+ Coverage   99.86%   99.86%   +<.01%     
  Files         238      238              
  Lines        4464     4476      +12     
  Branches     1254     1260       +6     
+ Hits         4458     4470      +12     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
src/components/dropdown/dropdown-header.js 100% <100%> (ø) ⬆️
src/components/dropdown/dropdown-form.js 100% <100%> (ø) ⬆️
src/components/dropdown/dropdown-group.js 100% <100%> (ø) ⬆️
src/components/dropdown/dropdown-text.js 100% <100%> (ø) ⬆️
src/components/dropdown/dropdown-divider.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7cb16f...59c4069. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review Sep 5, 2019
@tmorehouse tmorehouse requested a review from jacobmllr95 Sep 5, 2019
@tmorehouse tmorehouse changed the title fix(dropdown sub-components): ensure class bindings are placed on root element (closes #4022) fix(b-dropdown-*): ensure class bindings are placed on root element for all dropdown sub-components (closes #4022) Sep 5, 2019
@tmorehouse tmorehouse merged commit 81efb89 into dev Sep 5, 2019
9 checks passed
2.0.0 Stable automation moved this from In Progress to Completed Sep 5, 2019
@tmorehouse tmorehouse deleted the tmorehouse/dd-children branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No open projects
2.0.0 Stable

Successfully merging this pull request may close these issues.

2 participants