Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): link to options prop details section (closes #4035) #4036

Merged
merged 15 commits into from Sep 8, 2019

Conversation

@tmorehouse
Copy link
Member

commented Sep 7, 2019

Describe the PR

Updates links to the options prop section in the form select page

Closes #4035

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov

This comment has been minimized.

Copy link

commented Sep 7, 2019

Codecov Report

Merging #4036 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4036   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         238      238           
  Lines        4475     4475           
  Branches     1257     1257           
=======================================
  Hits         4469     4469           
  Misses          5        5           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb29d14...67a270e. Read the comment docs.

tmorehouse added 2 commits Sep 7, 2019

@tmorehouse tmorehouse removed the Status: WIP label Sep 7, 2019

tmorehouse added 4 commits Sep 7, 2019

@tmorehouse tmorehouse marked this pull request as ready for review Sep 7, 2019

@tmorehouse

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2019

This could be merged into master, as it is purely docs updates, which would update the published docs.

@tmorehouse tmorehouse changed the title chore(docs): link to options prop details section chore(docs): link to options prop details section (closes #4035) Sep 7, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Sep 7, 2019

tmorehouse and others added 6 commits Sep 7, 2019

@jackmu95 jackmu95 merged commit d236d92 into dev Sep 8, 2019

8 of 9 checks passed

License Compliance FOSSA is analyzing this commit
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing fb29d14...67a270e
Details
codecov/project 99.86% remains the same compared to fb29d14
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected

@jackmu95 jackmu95 deleted the tmorehouse/docs-options branch Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.