Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-b-tooltip, v-b-popover): don't show if no title/content provided (closes #4064) #4076

merged 20 commits into from Sep 11, 2019


Copy link

commented Sep 11, 2019

Describe the PR

For directive versions, if no content/title available, then don't show the tooltip or popover.

Handles special case when title/content is the number 0

Closes #4064

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
closes #4064)

This comment has been minimized.

Copy link

commented Sep 11, 2019

Codecov Report

Merging #4076 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4076   +/-   ##
  Coverage   99.86%   99.86%           
  Files         238      238           
  Lines        4470     4470           
  Branches     1260     1260           
  Hits         4464     4464           
  Misses          5        5           
  Partials        1        1
Impacted Files Coverage Δ
src/directives/tooltip/tooltip.js 100% <ø> (ø) ⬆️
.../components/popover/helpers/bv-popover-template.js 100% <ø> (ø) ⬆️
src/directives/popover/popover.js 100% <ø> (ø) ⬆️
src/components/tooltip/helpers/bv-tooltip.js 99.6% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddd115...614a275. Read the comment docs.

tmorehouse added 3 commits Sep 11, 2019
@tmorehouse tmorehouse marked this pull request as ready for review Sep 11, 2019
tmorehouse added 2 commits Sep 11, 2019
@tmorehouse tmorehouse requested a review from jackmu95 Sep 11, 2019
tmorehouse added 3 commits Sep 11, 2019
tmorehouse added 3 commits Sep 11, 2019

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

Making sure handles the case where title/content is the number 0

tmorehouse added 3 commits Sep 11, 2019
@tmorehouse tmorehouse removed the Status: WIP label Sep 11, 2019
jackmu95 and others added 3 commits Sep 11, 2019
@tmorehouse tmorehouse merged commit 0b7de29 into dev Sep 11, 2019
9 checks passed
9 checks passed
License Compliance All checks passed.
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
codecov/patch Coverage not affected when comparing 9ddd115...614a275
codecov/project 99.86% remains the same compared to 9ddd115
deploy/netlify Deploy preview ready!
security/snyk - package.json (pi0) No manifest changes detected
@tmorehouse tmorehouse deleted the issue/4064 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.