Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tables): add in missing Bootstrap variant class bg-active for dark tables #4098

merged 6 commits into from
Sep 18, 2019


Copy link

@tmorehouse tmorehouse commented Sep 14, 2019

Describe the PR

Bootstrap v4.3 does not generate a variant class bg-active for use in dark tables.

This adds in the missing class, but only for BootstrapVue tables (i.e. tables that have class b-table)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) SCSS

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Copy link

codecov bot commented Sep 14, 2019

Codecov Report

Merging #4098 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4098   +/-   ##
  Coverage   99.86%   99.86%           
  Files         238      238           
  Lines        4470     4470           
  Branches     1260     1260           
  Hits         4464     4464           
  Misses          5        5           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35ad51...f49e9e7. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review September 14, 2019 19:56
@tmorehouse tmorehouse changed the title feat(tables): add in missing Bootstrap bg-active class for dark tables fix(tables): add in missing Bootstrap bg-active class for dark tables Sep 14, 2019
@tmorehouse tmorehouse changed the title fix(tables): add in missing Bootstrap bg-active class for dark tables fix(tables): add in missing Bootstrap variant class bg-active for dark tables Sep 14, 2019
@tmorehouse tmorehouse added the PR: Patch Requires patch version bump label Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants