Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(b-nav-form, b-nav-text): ensure these sub-components have `<li>` as root element for accessibility #4100
Describe the PR
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
For users targeting specific child elements via CSS, they may need to adjust their selectors.
The PR fulfills these requirements:
If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
@@ Coverage Diff @@ ## dev #4100 +/- ## ========================================== + Coverage 99.86% 99.86% +<.01% ========================================== Files 237 237 Lines 4534 4538 +4 Branches 1280 1280 ========================================== + Hits 4528 4532 +4 Misses 5 5 Partials 1 1
This shouldn't be a breaking change for the majority of users, but those that might be expecting a certain root element for styling it might be.
But thinking it might be a big enough change that is should be in a minor release, rather than a patch release.