Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tables): ensure row variant `active` (class `table-active`) takes precedence over other row variants (addresses #3008) #4127

Merged
merged 8 commits into from Sep 19, 2019

Conversation

@tmorehouse
Copy link
Member

commented Sep 19, 2019

Describe the PR

Re-declares the table-active row variant class after any other row-variant classes so that it can take precedence when using it as the selected-variant for selectable rows.

Addresses #3008 (but only when using selected-variant="active")

To Do:

  • Add in :hover style handling for table-active/bg-active row variant class (borrow from sticky column hover handling)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) SCSS update

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
…other row variants
@codecov

This comment has been minimized.

Copy link

commented Sep 19, 2019

Codecov Report

Merging #4127 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4127   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         238      238           
  Lines        4471     4471           
  Branches     1260     1260           
=======================================
  Hits         4465     4465           
  Misses          5        5           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f079fcf...3e8f424. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(tables): ensure row variant `table-active` takes precedence over other row variants fix(tables): ensure row variant `table-active` takes precedence over other row variants (addresses #3008) Sep 19, 2019
@tmorehouse tmorehouse requested a review from jackmu95 Sep 19, 2019
@tmorehouse tmorehouse changed the title fix(tables): ensure row variant `table-active` takes precedence over other row variants (addresses #3008) fix(tables): ensure row variant `active` (class `table-active`) takes precedence over other row variants (addresses #3008) Sep 19, 2019
tmorehouse and others added 6 commits Sep 19, 2019
@jackmu95 jackmu95 marked this pull request as ready for review Sep 19, 2019
@tmorehouse tmorehouse removed the Status: WIP label Sep 19, 2019
@tmorehouse tmorehouse merged commit fdb8bb6 into dev Sep 19, 2019
9 checks passed
9 checks passed
License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f079fcf...3e8f424
Details
codecov/project 99.86% remains the same compared to f079fcf
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
@tmorehouse tmorehouse deleted the tmorehouse/table-active branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.