Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-table): default the row select feature `selected-variant` to the `active` variant #4128

Merged
merged 16 commits into from Oct 14, 2019

Conversation

@tmorehouse
Copy link
Member

tmorehouse commented Sep 19, 2019

Describe the PR

Changes the default selected-variant from primary to the more robust active variant for selectable tables.

To Do:

  • documentation updates.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

Not really breaking change, but if users were expecting the default of primary, it will now be active instead.

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@tmorehouse tmorehouse added this to In progress in 2.1.0 via automation Sep 19, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #4128 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4128   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         237      237           
  Lines        4539     4539           
  Branches     1281     1281           
=======================================
  Hits         4533     4533           
  Misses          5        5           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a822b...0233140. Read the comment docs.

@jackmu95 jackmu95 marked this pull request as ready for review Sep 21, 2019
jackmu95 and others added 8 commits Sep 21, 2019
tmorehouse and others added 3 commits Oct 11, 2019
@tmorehouse tmorehouse changed the title feat(b-table): default row select feature `selected-variant` to `active` feat(b-table): default the row select feature `selected-variant` to `active` Oct 14, 2019
@tmorehouse tmorehouse changed the title feat(b-table): default the row select feature `selected-variant` to `active` feat(b-table): default the row select feature `selected-variant` to the `active` variant Oct 14, 2019
tmorehouse added 2 commits Oct 14, 2019
@tmorehouse tmorehouse merged commit af372b0 into dev Oct 14, 2019
9 checks passed
9 checks passed
License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 21a822b...0233140
Details
codecov/project 99.86% remains the same compared to 21a822b
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
2.1.0 automation moved this from In progress to Done Oct 14, 2019
@tmorehouse tmorehouse deleted the tmorehouse/table-active-default branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.1.0
  
Done
2 participants
You can’t perform that action at this time.