Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-table): minor code optimizations to filter debouncing #4167

Merged
merged 6 commits into from Sep 30, 2019

Conversation

@tmorehouse
Copy link
Member

commented Sep 29, 2019

Describe the PR

A clear and concise description of what the pull request does.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) code refactor

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
tmorehouse added 2 commits Sep 29, 2019
@tmorehouse tmorehouse changed the title fix(b-table): minor optimizations to filter debouncing fix(b-table): minor code optimizations to filter debouncing Sep 29, 2019
@tmorehouse tmorehouse marked this pull request as ready for review Sep 29, 2019
@tmorehouse tmorehouse requested a review from jackmu95 Sep 29, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 30, 2019

Codecov Report

Merging #4167 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4167      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files         237      237              
  Lines        4495     4493       -2     
  Branches     1258     1257       -1     
==========================================
- Hits         4489     4487       -2     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
src/components/table/helpers/mixin-filtering.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e2e56...8b6c584. Read the comment docs.

tmorehouse added 2 commits Sep 30, 2019
@tmorehouse tmorehouse merged commit 018eef1 into dev Sep 30, 2019
8 of 9 checks passed
8 of 9 checks passed
License Compliance FOSSA is analyzing this commit
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.86%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.13% compared to a8e2e56
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
@tmorehouse tmorehouse deleted the tmorehouse/table-filter-debounce branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.