-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(b-form-file): fix prop type checking for value
prop
#4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow empty string to be passed. When creating the new props docs and web-types (not yet released), the value type was changed to `[File, Array]` from Any (`undefined`). The resetting of the file control can be done by setting to an empty string, and when doing so Vue would emit an prop type check warning. This adds back in the type String to prevent the warning.
Codecov Report
@@ Coverage Diff @@
## dev #4168 +/- ##
==========================================
+ Coverage 99.86% 99.86% +<.01%
==========================================
Files 237 237
Lines 4493 4495 +2
Branches 1258 1258
==========================================
+ Hits 4487 4489 +2
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
tmorehouse
changed the title
chore(b-form-file): Fix types allowed by value (Vue prop type check)
fix(b-form-file): fix prop type checking for Sep 29, 2019
value
tmorehouse
changed the title
fix(b-form-file): fix prop type checking for
fix(b-form-file): fix prop type checking for Sep 29, 2019
value
value
prop
jacobmllr95
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
When creating the new props docs and web-types (for yet to be released v2.0.3), the value type was changed to
[File, Array]
fromAny
(undefined
) for better prop docs generation.The resetting of the file control can be done by setting to
null
, and empty array, or an empty string, and when doing so Vue would emit an prop type check warning (when using empty string to reset the input).This adds a deprecation message to have users switch to setting to
null
instead of empty string, and uses a custom validator to check the prop type/valuePR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: