Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dropdown): show example of opening modal from dropdown item (closes #4149) #4186

Closed
wants to merge 3 commits into from

Conversation

@tmorehouse
Copy link
Member

commented Oct 3, 2019

Describe the PR

In dropdown accessibility docs, show example of opening a modal from a dropdown item.

Closes #4149

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@tmorehouse

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

It might be possible to actually get teh v-b-modal directive to check if it is on a dropdown-item (or nav-item) and move the listeners/role check to the inner <a> or <button> element

@codecov

This comment has been minimized.

Copy link

commented Oct 3, 2019

Codecov Report

Merging #4186 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4186   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         237      237           
  Lines        4495     4495           
  Branches     1259     1259           
=======================================
  Hits         4489     4489           
  Misses          5        5           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cee6c0...5c26cbd. Read the comment docs.

@tmorehouse

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

Closing in favour of #4187

@tmorehouse tmorehouse closed this Oct 3, 2019
@tmorehouse tmorehouse deleted the issue/4149 branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.