-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(b-table, b-table-lite): delegate row event handlers to the tbody element #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmorehouse
changed the title
perf(b-table, b-table-lite): delegate the row event handler to the tbody element
perf(b-table, b-table-lite): delegate row event handlers to the tbody element
Oct 4, 2019
Codecov Report
@@ Coverage Diff @@
## dev #4192 +/- ##
==========================================
+ Coverage 99.86% 99.86% +<.01%
==========================================
Files 237 237
Lines 4519 4527 +8
Branches 1267 1274 +7
==========================================
+ Hits 4513 4521 +8
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
jacobmllr95
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Use event delegation, where possible, on the tbody element for
row-*
event handling.This will reduce the number of native event listeners registered on each
tbody > tr
element, and reduce the number of anonymous function event handlers, which should help improve table rendering time and reduce run-time memory footprintFuture To Do:
row-*
event handlers if there are corresponding event listeners registeredPR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: