Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-form-select): add group/tree support and dedicated option and option-group components (closes #3222) #4267

Merged
merged 33 commits into from Nov 18, 2019

Conversation

@jackmu95
Copy link
Member

jackmu95 commented Oct 16, 2019

Describe the PR

This PR adds group/tree support for the <b-form-select> via the options property.
It adds also dedicated <b-form-select-option> and <b-form-select-option-group> components.

TODO:

  • Documentation update
  • Add tests

Closes #3222.
Replaces #4112.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
…option-group components
@jackmu95 jackmu95 requested a review from tmorehouse Oct 16, 2019
@jackmu95 jackmu95 added this to In progress in 2.1.0 via automation Oct 16, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #4267 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4267      +/-   ##
==========================================
+ Coverage   99.91%   99.91%   +<.01%     
==========================================
  Files         240      243       +3     
  Lines        4622     4632      +10     
  Branches     1303     1306       +3     
==========================================
+ Hits         4618     4628      +10     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/components/toast/toaster.js 100% <ø> (ø) ⬆️
src/components/tooltip/helpers/bv-tooltip.js 99.59% <ø> (ø) ⬆️
src/components/toast/helpers/bv-toast.js 100% <ø> (ø) ⬆️
src/index.js 100% <ø> (ø) ⬆️
src/components/modal/helpers/bv-modal.js 100% <ø> (ø) ⬆️
src/components/table/helpers/mixin-provider.js 100% <ø> (ø) ⬆️
src/components/form-select/index.js 100% <ø> (ø) ⬆️
src/components/pagination-nav/pagination-nav.js 100% <ø> (ø) ⬆️
...components/form-select/form-select-option-group.js 100% <100%> (ø)
src/components/form-file/form-file.js 96.07% <100%> (+0.07%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f5279...a0c02d8. Read the comment docs.

jackmu95 added 3 commits Oct 17, 2019
@tmorehouse tmorehouse moved this from In progress to Future in 2.1.0 Oct 30, 2019
@tmorehouse tmorehouse removed this from Future in 2.1.0 Oct 30, 2019
@tmorehouse tmorehouse added this to Features in Roadmap Oct 30, 2019
@jackmu95 jackmu95 added this to In progress in 2.2.0 via automation Nov 13, 2019
@jackmu95 jackmu95 removed this from Features in Roadmap Nov 13, 2019
jackmu95 and others added 11 commits Nov 13, 2019
jackmu95 added 6 commits Nov 18, 2019
@jackmu95 jackmu95 removed the Status: WIP label Nov 18, 2019
tmorehouse added 8 commits Nov 18, 2019
@jackmu95 jackmu95 merged commit f1ed017 into dev Nov 18, 2019
5 of 6 checks passed
5 of 6 checks passed
License Compliance FOSSA is analyzing this commit
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
security/snyk - package.json (pi0) No manifest changes detected
2.2.0 automation moved this from In progress to Done Nov 18, 2019
@jackmu95 jackmu95 deleted the feat-form-select-option-groups branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.2.0
  
Done
2 participants
You can’t perform that action at this time.