Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-dropdown): add `block` support to toggle button (closes #4266) #4269

Merged
merged 5 commits into from Oct 17, 2019

Conversation

@jackmu95
Copy link
Member

jackmu95 commented Oct 17, 2019

Describe the PR

This PR adds block support (similar to <b-button>) to the <b-dropdown>'s toggle.

TODO:

  • Documentation update
  • Add tests

Closes #4266.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@jackmu95 jackmu95 requested a review from tmorehouse Oct 17, 2019
@jackmu95 jackmu95 added this to In progress in 2.1.0 via automation Oct 17, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #4269 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4269   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         237      237           
  Lines        4548     4548           
  Branches     1280     1280           
=======================================
  Hits         4544     4544           
  Misses          3        3           
  Partials        1        1
Impacted Files Coverage Δ
src/components/dropdown/dropdown.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55787dd...e710488. Read the comment docs.

Copy link
Member

tmorehouse left a comment

Looks good... just need to add a few blurbs in the docs

tmorehouse and others added 3 commits Oct 17, 2019
@jackmu95 jackmu95 removed the Status: WIP label Oct 17, 2019
@jackmu95 jackmu95 requested a review from tmorehouse Oct 17, 2019
@jackmu95 jackmu95 requested a review from tmorehouse Oct 17, 2019
@jackmu95 jackmu95 merged commit 30029e3 into dev Oct 17, 2019
9 checks passed
9 checks passed
License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 55787dd...e710488
Details
codecov/project 99.91% remains the same compared to 55787dd
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
2.1.0 automation moved this from In progress to Done Oct 17, 2019
@jackmu95 jackmu95 deleted the feat-dropdown-block-support branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.1.0
  
Done
2 participants
You can’t perform that action at this time.