Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-types): update web-types code generation to match schema #4271

Merged
merged 3 commits into from Oct 18, 2019

Conversation

@piotrtomiak
Copy link
Contributor

piotrtomiak commented Oct 18, 2019

Describe the PR

Update web-types generation to match schema, improve descriptions on components and fix regular expressions.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@piotrtomiak

This comment has been minimized.

Copy link
Contributor Author

piotrtomiak commented Oct 18, 2019

@tmorehouse Please review :)

@piotrtomiak piotrtomiak force-pushed the piotrtomiak:fix-web-types branch from aff0981 to 4383764 Oct 18, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #4271 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4271   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         237      237           
  Lines        4548     4548           
  Branches     1280     1280           
=======================================
  Hits         4544     4544           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0be41...7eb5672. Read the comment docs.

@piotrtomiak piotrtomiak force-pushed the piotrtomiak:fix-web-types branch from 4383764 to cfa9764 Oct 18, 2019
@piotrtomiak

This comment has been minimized.

Copy link
Contributor Author

piotrtomiak commented Oct 18, 2019

With provided changes you'll get following documentation on components in WebStorm 2019.3 EAP:
Monosnap 2019-10-18 14-38-31

@tmorehouse tmorehouse changed the title fix(docs): update web-types code generation to match schema fix(web-types): update web-types code generation to match schema Oct 18, 2019
@tmorehouse tmorehouse merged commit 009431e into bootstrap-vue:dev Oct 18, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing ff0be41...7eb5672
Details
codecov/project 99.91% remains the same compared to ff0be41
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
@tmorehouse

This comment has been minimized.

Copy link
Member

tmorehouse commented Oct 18, 2019

Thanks!

@piotrtomiak piotrtomiak deleted the piotrtomiak:fix-web-types branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.