Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(web-types): update web-types code generation to match schema #4271
Conversation
This comment has been minimized.
This comment has been minimized.
@tmorehouse Please review :) |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Oct 18, 2019
•
Codecov Report
@@ Coverage Diff @@
## dev #4271 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 237 237
Lines 4548 4548
Branches 1280 1280
=======================================
Hits 4544 4544
Misses 3 3
Partials 1 1 Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
009431e
into
bootstrap-vue:dev
8 checks passed
8 checks passed
security/snyk - package.json (pi0)
No manifest changes detected
This comment has been minimized.
This comment has been minimized.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
piotrtomiak commentedOct 18, 2019
Describe the PR
Update web-types generation to match schema, improve descriptions on components and fix regular expressions.
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: