Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-table): add `selectRow()` and `unselectRow()` methods to cell and row-details slot scopes, and new prop `no-select-on-click` #4283

Merged
merged 29 commits into from Oct 21, 2019

Conversation

@tmorehouse
Copy link
Member

tmorehouse commented Oct 21, 2019

Describe the PR

Adds two methods to cell slot scope and row-details slot scope:

  • selectRow() to select the current row
  • unselectRow() to unselect the current row

Also adds option to disable row selection via row click via new prop no-select-on-click so that rows are only selectable programmatically (also disables keyboard navigation of rows)

To Do:

  • add in option to disable selecting rows via row-clicked (i.e. programmatic selection only)
  • update component package.json meta
  • update docs
  • additional unit testing

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
…details slot scopes
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #4283 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4283      +/-   ##
==========================================
+ Coverage   99.91%   99.91%   +<.01%     
==========================================
  Files         237      237              
  Lines        4550     4560      +10     
  Branches     1280     1282       +2     
==========================================
+ Hits         4546     4556      +10     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/components/table/helpers/mixin-tbody-row.js 100% <100%> (ø) ⬆️
src/components/table/helpers/mixin-selectable.js 100% <100%> (ø) ⬆️
src/components/table/helpers/mixin-tbody.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1246916...5c70cdb. Read the comment docs.

tmorehouse added 3 commits Oct 21, 2019
@tmorehouse tmorehouse changed the title feat(b-table): add selectRow() and unselectRow() methods to cell and row-details slot scopes feat(b-table): add `selectRow()` and `unselectRow()` methods to cell and row-details slot scopes Oct 21, 2019
tmorehouse added 18 commits Oct 21, 2019
@tmorehouse tmorehouse added this to In progress in 2.1.0 via automation Oct 21, 2019
tmorehouse added 4 commits Oct 21, 2019
@tmorehouse tmorehouse marked this pull request as ready for review Oct 21, 2019
@tmorehouse tmorehouse requested a review from jackmu95 Oct 21, 2019
@tmorehouse tmorehouse removed the Status: WIP label Oct 21, 2019
@tmorehouse tmorehouse changed the title feat(b-table): add `selectRow()` and `unselectRow()` methods to cell and row-details slot scopes feat(b-table): add `selectRow()` and `unselectRow()` methods to cell and row-details slot scopes, and new prop `no-select-on-click` Oct 21, 2019
@tmorehouse tmorehouse merged commit 64b881f into dev Oct 21, 2019
9 checks passed
9 checks passed
License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.91%)
Details
codecov/project 99.91% (+<.01%) compared to 1246916
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
2.1.0 automation moved this from In progress to Done Oct 21, 2019
@tmorehouse tmorehouse deleted the feat/table-select branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.1.0
  
Done
2 participants
You can’t perform that action at this time.